linux-kernel - Re: [PATCH] kbuild: use hostname -s along uname to obtain LINUX_COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNARvEsh3+dix+EdcXnm2L0rh8hndQD5N2vyc0q_c0Vf7gQ@mail.gmail.com>
Date:   Fri, 1 Apr 2022 23:04:47 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     FraSharp <f.duca00@...il.com>
Cc:     Francesco Duca <s23265@...ve.it>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: use hostname -s along uname to obtain LINUX_COMPILE_HOST

On Thu, Mar 31, 2022 at 3:23 AM FraSharp <f.duca00@...il.com> wrote:
>
> From: Francesco Duca <s23265@...ve.it>
>
> * On some systems (e.g. macOS), using commands like 'uname -n' or
>   'hostname' will print something similar to "hostname.domain"


Not only macOS, but also on Linux systems such as Fedora, Debian.

'uname -s' or 'hostname' prints "hostname.domain"




>   ("Francescos-Air.fritz.box" for example), which is very annoying.

I do not think so.


>   What works instead is 'hostname -s', which will only write hostname
>   without the domain ("Francescos-Air" for example),
>   but also keep 'uname -n', as some systems as Arch Linux does not have
>   'hostname' as command.

If so, on Arch Linux, will this patch spit
  hostname: command not found
error message because   "2>/dev/null" is missing ?


And, the intention of this patch is,
print  Francescos-Air if the 'hostname -s' command is available,
but Francescos-Air.fritz.box  otherwise, correct  ?






>
> * This commit is complementary to
>   1e66d50ad3a1dbf0169b14d502be59a4b1213149
>   ("kbuild: Use uname for LINUX_COMPILE_HOST detection")
>
> Signed-off-by: Francesco Duca <s23265@...ve.it>
> ---
>  scripts/mkcompile_h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/mkcompile_h b/scripts/mkcompile_h
> index ca40a5258..6054e3eee 100755
> --- a/scripts/mkcompile_h
> +++ b/scripts/mkcompile_h
> @@ -34,7 +34,7 @@ else
>         LINUX_COMPILE_BY=$KBUILD_BUILD_USER
>  fi
>  if test -z "$KBUILD_BUILD_HOST"; then
> -       LINUX_COMPILE_HOST=`uname -n`
> +       LINUX_COMPILE_HOST=$(hostname -s || uname -n)
>  else
>         LINUX_COMPILE_HOST=$KBUILD_BUILD_HOST
>  fi
> --
> 2.32.0 (Apple Git-132)
>


-- 
Best Regards
Masahiro Yamada