linux-kernel - Re: [PATCH v5 1/1] serial/8250: Use fifo in 8250 console driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAq0SUmZ1u0TLTOq9fcn68oTZ6iHmpALbjhhy3zh6T=Kz1afxg@mail.gmail.com>
Date:   Fri, 1 Apr 2022 11:26:15 -0300
From:   Wander Costa <wcosta@...hat.com>
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     Wander Lairson Costa <wander@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johan Hovold <johan@...nel.org>,
        "Maciej W. Rozycki" <macro@...am.me.uk>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Lukas Wunner <lukas@...ner.de>,
        Pali Rohár <pali@...nel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        André Goddard Rosa <andre.goddard@...il.com>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        David Laight <David.Laight@...lab.com>,
        Jon Hunter <jonathanh@...dia.com>, phil@...pberrypi.com
Subject: Re: [PATCH v5 1/1] serial/8250: Use fifo in 8250 console driver

On Fri, Apr 1, 2022 at 1:36 AM Jiri Slaby <jirislaby@...nel.org> wrote:
>

>
> ">" missing here. Doesn't a compiler warn about subtracting different types?
>

My local machine doesn't generate a warning; it causes a build error.
So my question was, how was I able to build and test yesterday in a
remote server? It turns out I built it with make -j40, so I missed the
error message because of the parallel build, and I didn't pay
attention that the output didn't display the modules_install typical
output. Usually, I do my tests in an RHEL9 machine, which ships with
kernel 5.14, but this time I tested in a Fedora machine, which ships
kernel 5.16. And for a moment, I forgot that. So when I booted with
kernel 5.16, I believed I was running my custom kernel. Luckily, v5
mainly was a squash of v4 with this port->state check added. Anyway,
sorry about the typo. v6 is on the way.