linux-kernel - Re: [PATCH v13 1/2] dt-bindings: mmc: mtk-sd: increase reg items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53cb53b8614aa39e0785b99f46b708ad201c3dd8.camel@mediatek.com>
Date:   Fri, 1 Apr 2022 10:18:08 +0800
From:   Tinghan Shen <tinghan.shen@...iatek.com>
To:     Matthias Brugger <matthias.bgg@...il.com>,
        Chaotian Jing <chaotian.jing@...iatek.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Wenbin Mei <wenbin.mei@...iatek.com>
CC:     <linux-mmc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        <ryder.lee@...nel.org>, <wenst@...omium.org>,
        <chunfeng.yun@...iatek.com>
Subject: Re: [PATCH v13 1/2] dt-bindings: mmc: mtk-sd: increase reg items

Hi Matthias,

On Thu, 2022-03-31 at 12:54 +0200, Matthias Brugger wrote:
> 
> On 30/03/2022 11:45, Tinghan Shen wrote:
> > MediaTek has a new version of mmc IP since mt8183. Some IO registers
> > are moved to top to improve hardware design and named as "host top
> > registers".
> > 
> > Add host top register in the reg binding description for mt8183 and
> > successors.
> > 
> > Signed-off-by: Wenbin Mei <wenbin.mei@...iatek.com>
> > Signed-off-by: Tinghan Shen <tinghan.shen@...iatek.com>
> > ---
> >   Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 15 ++++++++++++++-
> >   1 file changed, 14 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index 297ada03e3de..2a2e9fa8c188 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -40,7 +40,10 @@ properties:
> >             - const: mediatek,mt8183-mmc
> >   
> >     reg:
> > -    maxItems: 1
> > +    minItems: 1
> 
>  From my understanding adding minItems is correct, but you need to add also 
> maxItems: 2 as there can't be more then two register entries.
> 
> Regards,
> Matthias
> 

After add "maxItems: 2", I get following message when doing dt_binding_check.
from this message, it looks like that maxItems is not necessary.

/proj/mtk15399/2cros/src/third_party/kernel/v5.10/Documentation/devicetree/bindings/mmc/mtk-sd.yaml: 
properties:reg: {'minItems': 1, 'maxItems': 2, 'items': [{'description': 'base register
(required).'}, {'description': 'top base register (required for MT8183).'}]} should not be valid
under {'required': ['maxItems']}
        hint: "maxItems" is not needed with an "items" list
        from schema $id: http://devicetree.org/meta-schemas/items.yaml#
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json

Best regards,
Tinghan

> > +    items:
> > +      - description: base register (required).
> > +      - description: top base register (required for MT8183).
> >   
> >     clocks:
> >       description:
> > @@ -168,6 +171,16 @@ required:
> >     - vmmc-supply
> >     - vqmmc-supply
> >   
> > +if:
> > +  properties:
> > +    compatible:
> > +      contains:
> > +        const: mediatek,mt8183-mmc
> > +then:
> > +  properties:
> > +    reg:
> > +      minItems: 2
> > +
> >   unevaluatedProperties: false
> >   
> >   examples: