linux-kernel - Re: [PATCH] ACPI: OSL: Fix the memory mapping of an ACPI GAS that addresses a data structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202204021406.lxRmdIm5-lkp@intel.com>
Date:   Sat, 2 Apr 2022 15:01:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     james.liu@....com, rafael@...nel.org, lenb@...nel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        rwright@....com, david.chang@....co, clayc@....com,
        james.liu@....com
Subject: Re: [PATCH]     ACPI: OSL: Fix the memory mapping of an ACPI GAS
 that addresses a data structure

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on v5.17 next-20220401]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/james-liu-hpe-com/ACPI-OSL-Fix-the-memory-mapping-of-an-ACPI-GAS-that-addresses-a-data-structure/20220402-013755
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-randconfig-a012 (https://download.01.org/0day-ci/archive/20220402/202204021406.lxRmdIm5-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c4a1b07d0979e7ff20d7d541af666d822d66b566)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/594496ff7d62c6d42b3c8a436fca46cc289aea67
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review james-liu-hpe-com/ACPI-OSL-Fix-the-memory-mapping-of-an-ACPI-GAS-that-addresses-a-data-structure/20220402-013755
        git checkout 594496ff7d62c6d42b3c8a436fca46cc289aea67
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/acpi/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/acpi/osl.c:463:29: warning: variable 'addr' is uninitialized when used here [-Wuninitialized]
                   return  acpi_os_map_iomem(addr, PAGE_SIZE);
                                             ^~~~
   drivers/acpi/osl.c:455:10: note: initialize the variable 'addr' to silence this warning
           u64 addr;
                   ^
                    = 0
   drivers/acpi/osl.c:487:25: warning: variable 'addr' is uninitialized when used here [-Wuninitialized]
                   map = acpi_map_lookup(addr, PAGE_SIZE);
                                         ^~~~
   drivers/acpi/osl.c:477:10: note: initialize the variable 'addr' to silence this warning
           u64 addr;
                   ^
                    = 0
   2 warnings generated.


vim +/addr +463 drivers/acpi/osl.c

   452	
   453	void __iomem *acpi_os_map_generic_address(struct acpi_generic_address *gas)
   454	{
   455		u64 addr;
   456	
   457		if (gas->space_id != ACPI_ADR_SPACE_SYSTEM_MEMORY)
   458			return NULL;
   459	
   460		/* Handle a case that GAS is used to address an ACPI data structure */
   461		if (!gas->bit_width) {
   462			pr_info("An ACPI data structure at 0x%llx is mapped\n", addr);
 > 463			return  acpi_os_map_iomem(addr, PAGE_SIZE);
   464		}
   465	
   466		/* Handle possible alignment issues */
   467		memcpy(&addr, &gas->address, sizeof(addr));
   468		if (!addr)
   469			return NULL;
   470	
   471		return acpi_os_map_iomem(addr, gas->bit_width / 8);
   472	}
   473	EXPORT_SYMBOL(acpi_os_map_generic_address);
   474	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp