linux-kernel - Re: [PATCH v13 1/2] dt-bindings: mmc: mtk-sd: increase reg items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d66c6ce-80d9-3a09-b34c-7ae5a7763465@linaro.org>
Date:   Sat, 2 Apr 2022 18:21:03 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Tinghan Shen <tinghan.shen@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Chaotian Jing <chaotian.jing@...iatek.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Wenbin Mei <wenbin.mei@...iatek.com>
Cc:     linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com,
        ryder.lee@...nel.org, wenst@...omium.org, chunfeng.yun@...iatek.com
Subject: Re: [PATCH v13 1/2] dt-bindings: mmc: mtk-sd: increase reg items

On 01/04/2022 04:18, Tinghan Shen wrote:
> Hi Matthias,
> 
> On Thu, 2022-03-31 at 12:54 +0200, Matthias Brugger wrote:
>>
>> On 30/03/2022 11:45, Tinghan Shen wrote:
>>> MediaTek has a new version of mmc IP since mt8183. Some IO registers
>>> are moved to top to improve hardware design and named as "host top
>>> registers".
>>>
>>> Add host top register in the reg binding description for mt8183 and
>>> successors.
>>>
>>> Signed-off-by: Wenbin Mei <wenbin.mei@...iatek.com>
>>> Signed-off-by: Tinghan Shen <tinghan.shen@...iatek.com>
>>> ---
>>>   Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 15 ++++++++++++++-
>>>   1 file changed, 14 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> index 297ada03e3de..2a2e9fa8c188 100644
>>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> @@ -40,7 +40,10 @@ properties:
>>>             - const: mediatek,mt8183-mmc
>>>   
>>>     reg:
>>> -    maxItems: 1
>>> +    minItems: 1
>>
>>  From my understanding adding minItems is correct, but you need to add also 
>> maxItems: 2 as there can't be more then two register entries.
>>
>> Regards,
>> Matthias
>>
> 
> After add "maxItems: 2", I get following message when doing dt_binding_check.
> from this message, it looks like that maxItems is not necessary.


That's correct, you don't need them because "items" defines it.


Best regards,
Krzysztof