linux-kernel - Re: staging: r8188eu: how to handle nested mutex under spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <46a63481-d2e8-6c9d-b00d-a0e384e3f2af@gmail.com>
Date:   Sun, 3 Apr 2022 14:14:19 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Pavel Skripkin <paskripkin@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: staging: r8188eu: how to handle nested mutex under spinlock

On 4/3/22 13:56, Fabio M. De Francesco wrote:
> On domenica 3 aprile 2022 13:48:31 CEST Pavel Skripkin wrote:
>> Hi Michael,
>>
>> msleep() cannot be called in atomic context:
>>
>> drivers/staging/r8188eu/core/rtw_pwrctrl.c:379
>>
>>    	if (pwrpriv->ps_processing) {
>>    		while (pwrpriv->ps_processing && rtw_get_passing_time_ms(start) <= 3000)
>>    			msleep(10);
>>    	}

Ah, just another issue...

> 
> I wanted to use mdelay() (allowed under spinlocks because it does not
> sleep) but Dan said to leave it as it is. You might easily find this
> discussion on this list. I cannot remember why Dan was against replacing
> msleep() with mdelay(). Please try to find that thread.
> 

I'll take a breath and look further into it later. Seems a solution like
the one Larry mentioned is reasonable here.

Thank you both,
Michael