linux-kernel - [PATCH] raid6test: change dataoffs from global to static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220403133051.3751572-1-trix@redhat.com>
Date:   Sun,  3 Apr 2022 09:30:51 -0400
From:   Tom Rix <trix@...hat.com>
To:     dan.j.williams@...el.com, herbert@...dor.apana.org.au,
        davem@...emloft.net, jarkko@...nel.org
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tom Rix <trix@...hat.com>
Subject: [PATCH] raid6test: change dataoffs from global to static

Smatch reports this issue
raid6test.c:21:14: warning: symbol 'dataoffs'
  was not declared. Should it be static?

dataoffs is only used in raid6test.c.  File
scope variables used only in one file should
be static. Change dataoffs' storage-class-specifier
from global to static.

Signed-off-by: Tom Rix <trix@...hat.com>
---
 crypto/async_tx/raid6test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/async_tx/raid6test.c b/crypto/async_tx/raid6test.c
index c9d218e53bcb..d2d5fb154cda 100644
--- a/crypto/async_tx/raid6test.c
+++ b/crypto/async_tx/raid6test.c
@@ -18,7 +18,7 @@
 #define NDISKS 64 /* Including P and Q */
 
 static struct page *dataptrs[NDISKS];
-unsigned int dataoffs[NDISKS];
+static unsigned int dataoffs[NDISKS];
 static addr_conv_t addr_conv[NDISKS];
 static struct page *data[NDISKS+3];
 static struct page *spare;
-- 
2.27.0