linux-kernel - Re: [PATCH] staging: r8188eu: simplify control flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ccc9ac3-c542-cd32-0cbb-7cdabbf0dbf9@gmail.com>
Date:   Sun, 3 Apr 2022 19:16:10 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Sevinj Aghayeva <sevinj.aghayeva@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: r8188eu: simplify control flow

Hi Sevinj,

On 4/3/22 19:12, Sevinj Aghayeva wrote:
>>
>> Looks good, but let's not introduce new checkpatch issue:
>>
>> CHECK: Alignment should match open parenthesis
>> #62: FILE: drivers/staging/r8188eu/core/rtw_mlme.c:1645:
>> +               if ((p->PMKIDList[i].bUsed) &&
>> +                               (!memcmp(p->PMKIDList[i].Bssid, bssid, ETH_ALEN)))
> 
> Thanks for catching this. I wasn't seeing this in my checkpatch
> output, and after some digging, I could reproduce it with --strict
> option. I think the tutorial at
> https://kernelnewbies.org/PatchPhilosophy doesn't mention this option,
> so perhaps we should update it?!
> 

To be honest, I am not checkpatch expert, but checkpatch on my PC shows 
this warning w/o any additional options:

└──$ ./scripts/checkpatch.pl 
./20220403_sevinj_aghayeva_staging_r8188eu_simplify_control_flow.mbx | 
rg Alignment
CHECK: Alignment should match open parenthesis





With regards,
Pavel Skripkin

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)