linux-kernel - Re: [PATCH] staging: r8188eu: simplify control flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMWRUK5Ws=QvKvOAQ=iHtTNK8c3zvWJeOWoTEu2CUjrPCFuBEA@mail.gmail.com>
Date:   Sun, 3 Apr 2022 12:59:51 -0400
From:   Sevinj Aghayeva <sevinj.aghayeva@...il.com>
To:     Michael Straube <straube.linux@...il.com>
Cc:     Pavel Skripkin <paskripkin@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: r8188eu: simplify control flow

On Sun, Apr 3, 2022 at 12:43 PM Michael Straube <straube.linux@...il.com> wrote:
>
> On 4/3/22 18:29, Sevinj Aghayeva wrote:
> > Ah, I see. You run it on an email file that contains the patch. I
> > could reproduce what you saw when I ran checkpatch without any options
> > on an email file. But my usual workflow is to modify a file, e.g.
> > rtw_mlme.c and then run "checkpatch.pl -f rtw_mlme.c", in which case I
> > cannot see the "Alignment should match" error. So it looks like if you
> > do not specify -f then checkpatch.pl enables --strict option.
> >
>
> Hi Sevinj,
>
> I'm also not a checkpatch expert, but on my system this works without
> --strict too. I applied your patch to my local tree and get:
>
> /scripts/checkpatch.pl -f drivers/staging/r8188eu/core/rtw_mlme.c

Hi Michael,

That's odd. I don't get any CHECK messages if I run exactly the same
command as above:

$ pwd
/home/sevinj/k/staging/drivers/staging/r8188eu/core
$ ~/k/staging/scripts/checkpatch.pl -f rtw_mlme.c | grep 'CHECK:' | wc -l
0

I have to specify --strict to get CHECK messages:

$ ~/k/staging/scripts/checkpatch.pl --strict -f rtw_mlme.c | grep
'CHECK:' | wc -l
167

I don't know why that is. I'm on Ubuntu 20.04 and it looks like I'm
running checkpatch version 0.32:

$ ~/k/staging/scripts/checkpatch.pl -h
Usage: /home/sevinj/k/staging/scripts/checkpatch.pl [OPTION]... [FILE]...
Version: 0.32

<snip>

>
> [snip]
>
> CHECK: Alignment should match open parenthesis
> #1638: FILE: drivers/staging/r8188eu/core/rtw_mlme.c:1638:
> +               if ((p->PMKIDList[i].bUsed) &&
> +                               (!memcmp(p->PMKIDList[i].Bssid, bssid,
> ETH_ALEN)))
>
> [snip]
>
> You can also run checkpatch on the patch files (without -f).
> Then it's easier to see if you introduced new issues.
>
> regards,
> Michael



-- 

Sevinj.Aghayeva