linux-kernel - Re: [PATCH] staging: wfx: change variable name to be consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2021471.8hb0ThOEGa@pc-42>
Date:   Sun, 03 Apr 2022 22:34:59 +0200
From:   Jérôme Pouiller <jerome.pouiller@...abs.com>
To:     Jaehee Park <jhpark1013@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: wfx: change variable name to be consistent

On Sunday 3 April 2022 13:01:50 CEST Greg Kroah-Hartman wrote:
> On Fri, Apr 01, 2022 at 10:53:50AM -0400, Jaehee Park wrote:
> > Change variable name to be consistent with the naming conventions.
> > ssidlen was changed to ssid_len and ssidie was changed to ssid_ie to be
> > consistent. This makes the variables more readable. The other ssid
> > names in the code are separated by an underscore. For example,
> > bssid_filter and num_of_ssids have the ssid separated from the rest of
> > the words with an underscore.
> >
> > Signed-off-by: Jaehee Park <jhpark1013@...il.com>
> > ---
> >  drivers/staging/wfx/hif_tx.c | 10 +++++-----
> >  drivers/staging/wfx/sta.c    | 20 ++++++++++----------
> >  2 files changed, 15 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c
> > index ae3cc5919dcd..9c653d0e9034 100644
> > --- a/drivers/staging/wfx/hif_tx.c
> > +++ b/drivers/staging/wfx/hif_tx.c
> > @@ -280,7 +280,7 @@ int wfx_hif_stop_scan(struct wfx_vif *wvif)
> >  }
> >
> >  int wfx_hif_join(struct wfx_vif *wvif, const struct ieee80211_bss_conf *conf,
> > -              struct ieee80211_channel *channel, const u8 *ssid, int ssidlen)
> > +              struct ieee80211_channel *channel, const u8 *ssid, int ssid_len)
> 
> This is not really a "coding style" cleanup, it is up to the driver
> author how they wish to name these variables.  It is not a requirement
> to change them as the orginal names are just fine.

I have no real opinion. Let's say you can apply it:

Signed-off-by: Jérôme Pouiller <jerome.pouiller@...abs.com>

-- 
Jérôme Pouiller