linux-kernel - Re: [PATCH v2] usb: gadget: uvc: allow changing interface name via configfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4377408-ace7-a041-084f-5863bcfb7184@gmail.com>
Date:   Sun, 3 Apr 2022 13:13:02 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Dan Vacura <w36195@...orola.com>, linux-usb@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Corbet <corbet@....net>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Felipe Balbi <balbi@...nel.org>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Carlos Bilbao <bilbao@...edu>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v2] usb: gadget: uvc: allow changing interface name via
 configfs

On 01/04/22 23.04, Dan Vacura wrote:
> Add a configfs entry, "function_name", to change the iInterface field
> for VideoControl. This name is used on host devices for user selection,
> useful when multiple cameras are present. The default will remain "UVC
> Camera".
> 
> Signed-off-by: Dan Vacura <w36195@...orola.com>
> ---
> Changes in v2:
> - remove stable cc
> 
>   .../ABI/testing/configfs-usb-gadget-uvc       |  1 +
>   Documentation/usb/gadget-testing.rst          |  1 +
>   drivers/usb/gadget/function/f_uvc.c           |  4 +-
>   drivers/usb/gadget/function/u_uvc.h           |  1 +
>   drivers/usb/gadget/function/uvc_configfs.c    | 41 +++++++++++++++++++
>   5 files changed, 47 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/ABI/testing/configfs-usb-gadget-uvc b/Documentation/ABI/testing/configfs-usb-gadget-uvc
> index 889ed45be4ca..611b23e6488d 100644
> --- a/Documentation/ABI/testing/configfs-usb-gadget-uvc
> +++ b/Documentation/ABI/testing/configfs-usb-gadget-uvc
> @@ -7,6 +7,7 @@ Description:	UVC function directory
>   		streaming_maxburst	0..15 (ss only)
>   		streaming_maxpacket	1..1023 (fs), 1..3072 (hs/ss)
>   		streaming_interval	1..16
> +		function_name		string [32]
>   		===================	=============================

Since you mention that default function_name is "UVC Camera", why don't you
mention it in the documentation?

-- 
An old man doll... just what I always wanted! - Clara