linux-kernel - Re: [PATCH] usb: Prepare cleanup of powerpc's asm/prom.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 3 Apr 2022 11:50:37 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alan Stern <stern@...land.harvard.edu>
CC:     <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] usb: Prepare cleanup of powerpc's asm/prom.h

Hello!

On 4/2/22 1:21 PM, Christophe Leroy wrote:

> powerpc's asm/prom.h brings some headers that it doesn't
> need itself.
> 
> In order to clean it up, first add missing headers in
> users of asm/prom.h

   I'm not seeing any headers added in this patch?

> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> ---
>  drivers/usb/core/hcd-pci.c     | 1 -
>  drivers/usb/host/ohci-ppc-of.c | 3 ---
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
> index 8176bc81a635..f192925f74f7 100644
> --- a/drivers/usb/core/hcd-pci.c
> +++ b/drivers/usb/core/hcd-pci.c
> @@ -15,7 +15,6 @@
>  #ifdef CONFIG_PPC_PMAC
>  #include <asm/machdep.h>
>  #include <asm/pmac_feature.h>
> -#include <asm/prom.h>
>  #endif
>  
>  #include "usb.h"
> diff --git a/drivers/usb/host/ohci-ppc-of.c b/drivers/usb/host/ohci-ppc-of.c
> index 45f7cceb6df3..1960b8dfdba5 100644
> --- a/drivers/usb/host/ohci-ppc-of.c
> +++ b/drivers/usb/host/ohci-ppc-of.c
> @@ -19,9 +19,6 @@
>  #include <linux/of_irq.h>
>  #include <linux/of_platform.h>
>  
> -#include <asm/prom.h>
> -
> -
>  static int
>  ohci_ppc_of_start(struct usb_hcd *hcd)
>  {

MBR, Sergey