linux-kernel - Re: [PATCH] random: fix add_hwgenerator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9rKFfv+=Yvu2HZEjLZs1MPLrkHQTA1iLikVf2dxC998YQ@mail.gmail.com>
Date:   Mon, 4 Apr 2022 18:10:55 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Jan Varho <jan.varho@...il.com>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] random: fix add_hwgenerator_randomness entropy accounting

Hi Jan,

On Mon, Apr 4, 2022 at 5:29 PM Jan Varho <jan.varho@...il.com> wrote:
> I thought about doing it that way, but the return value allows
> checking that any input was actually used instead of fast init
> completing in the mean time.

I'm not too worried about races here. If lots of things are fighting
to inject entropy here, we're not in a starved situation. Also, the
other callers aren't looking at the return value. Let's keep it
simple; there's little harm in doing so in this instance.

Jason