[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 4 Apr 2022 16:42:18 -0500
From: Rob Herring <robh@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>,
ChiYuan Huang <cy_huang@...htek.com>,
linux-kernel@...r.kernel.org,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>, devicetree@...r.kernel.org
Subject: Re: [RFT PATCH 1/2] regulator: dt-bindings: richtek,rt4801: use
existing ena_gpiod feature
On Fri, 01 Apr 2022 17:42:36 +0200, Krzysztof Kozlowski wrote:
> The binding and driver duplicated regulator core feature of controlling
> regulators with GPIOs (of_parse_cb + ena_gpiod) and created its own
> enable-gpios property with multiple GPIOs.
>
> This is a less preferred way, because enable-gpios should enable only one
> element, not multiple. It also duplicates existing solution.
>
> Deprecate the original 'enable-gpios' and add per-regulator property.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> .../regulator/richtek,rt4801-regulator.yaml | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists