linux-kernel - Re: [PATCH V8 1/7] dt-bindings: mfd: pm8008: Modify the compatible as per driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Apr 2022 18:23:18 +0530
From:   "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>
CC:     Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Das Srinagesh <gurus@...eaurora.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_collinsd@...cinc.com>,
        <quic_subbaram@...cinc.com>, <quic_jprakash@...cinc.com>
Subject: Re: [PATCH V8 1/7] dt-bindings: mfd: pm8008: Modify the compatible as
 per driver


On 4/1/2022 2:45 AM, Stephen Boyd wrote:
> Quoting Satya Priya Kakitapalli (Temp) (2022-03-30 03:55:03)
>> On 3/25/2022 11:32 PM, Stephen Boyd wrote:
>>> Quoting Satya Priya (2022-03-25 04:58:05)
>>>> Modify the compatible string as per the pm8008 mfd driver.
>>>> Add reset-gpios property and make interrupts and interrupt-cells
>>>> as optional properties, they are not strictly required and may
>>>> cause yaml compilation errors when not added in the DT files.
>>> Does it have an interrupt controller inside? If so, the properties
>>> should be present even if the driver isn't using them.
>>
>> Yes it has an interrupt controller but we are not configuring/using any
>> interrupts currently in the DT node. So, if we add the properties under
>> "required" list it throws a make dtbs error. Do you think we can somehow
>> bypass this error?
>>
> Can you fix the existing node to have those properties?


Okay.


>>>> Also, change the node name in example to match with the
>>>> pm8008_infra DT node.
>>>>
>>>> Signed-off-by: Satya Priya <quic_c_skakit@...cinc.com>
>>>> ---
>>>> Changes in V5:
>>>>    - Remove compatible for regulators node.
>>>>    - Move supply nodes of the regulators to chip level.
>>>>
>>>> Changes in V6:
>>>>    - No changes.
>>>>
>>>> Changes in V7:
>>>>    - Removed the intermediate regulators node and added ldos
>>>>      directly under mfd node.
>>>>
>>>> Changes in V8:
>>>>    - Change the compatible as per driver, remove interrupts from required
>>>>      properties, add reset-gpios and move regulators to separate binding.
>>>>
>>>>    Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml | 15 ++++++++++-----
>>>>    1 file changed, 10 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
>>>> index ec3138c..12431ea 100644
>>>> --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
>>>> +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
>>>> @@ -16,7 +16,7 @@ description: |
>>>>
>>>>    properties:
>>>>      compatible:
>>>> -    const: qcom,pm8008
>>>> +    const: qcom,pm8008-infra
>>> Why is the compatible being replaced with -infra postfix?
>>
>> I've changed the compatible after splitting the probe into two parts
>> pm8008-infra-probe and pm8008-regulators-probe. Only reason for change
>> is to make it more readable/understandable.
>>
>>
> Please leave the pm8008 compatible alone.


Okay.