linux-kernel - Re: [PATCH v2] audit: do a quick exit when syscall number is less than 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Apr 2022 09:12:13 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     cgel.zte@...il.com
Cc:     eparis@...hat.com, linux-audit@...hat.com, rth@...ddle.net,
        sgrubb@...hat.com, linux-kernel@...r.kernel.org,
        ink@...assic.park.msu.ru, mattst88@...il.com,
        Yang Yang <yang.yang29@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH v2] audit: do a quick exit when syscall number is less
 than 0

On Sun, Apr 3, 2022 at 10:23 PM <cgel.zte@...il.com> wrote:
>
> From: Yang Yang <yang.yang29@....com.cn>
>
> Userspace may use syscall with syscall number less than 0 by calling
> syscall(syscall_num,..). This kind of syscall could never be audited,
> because auditctl requires rule with syscall number >=0. Therefore we
> better do a quick handle no need to gohead with this situation.
>
> Note that auditctl may set rules auditing invalid syscall with syscall
> number bigger than NR_syscalls, to keep this mechanism working, we do
> no more check(context->major bigger than NR_syscalls or not).
>
> Signed-off-by: Yang Yang <yang.yang29@....com.cn>
> Reported-by: Zeal Robot <zealci@....com.cn>
> ---
> v2:
> - cancel checking against NR_syscalls
> ---
>  kernel/auditsc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

As discussed previously, this is not something I want to merge
upstream at this time.

-- 
paul-moore.com