linux-kernel - Re: [PATCH linux-next v2] RDMA: simplify if-if to if-else

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Apr 2022 10:56:09 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Guo Zhengkui <guozhengkui@...o.com>
Cc:     Mustafa Ismail <mustafa.ismail@...el.com>,
        Shiraz Saleem <shiraz.saleem@...el.com>,
        Yishai Hadas <yishaih@...dia.com>,
        "open list:INTEL ETHERNET PROTOCOL DRIVER FOR RDMA" 
        <linux-rdma@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        zhengkui_guo@...look.com
Subject: Re: [PATCH linux-next v2] RDMA: simplify if-if to if-else

On Thu, Mar 31, 2022 at 09:05:25PM +0800, Guo Zhengkui wrote:
> @@ -632,7 +632,7 @@ static int handle_join_req(struct mcast_group *group, u8 join_mask,
>  			kfree(req);
>  			ref = 1;
>  			group->state = group->prev_state;
> -		} else
> +		} else {
>  			group->state = MCAST_JOIN_SENT;
>  	}

This doesn't compile.

Jason