lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 Apr 2022 10:03:51 -0700 From: Nick Desaulniers <ndesaulniers@...gle.com> To: Masahiro Yamada <masahiroy@...nel.org> Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, Michal Marek <michal.lkml@...kovi.net> Subject: Re: [PATCH 2/2] modpost: move export_from_secname() call to more relevant place On Sat, Apr 2, 2022 at 6:00 AM Masahiro Yamada <masahiroy@...nel.org> wrote: > > The value returned by export_from_secname() is only used by > sym_add_exported(). > > Move export_from_secname() just above sym_add_exported(). > > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org> Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com> > --- > > scripts/mod/modpost.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index 194ca9083c7a..f9e54247ae1d 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -684,12 +684,8 @@ static void handle_modversion(const struct module *mod, > static void handle_symbol(struct module *mod, struct elf_info *info, > const Elf_Sym *sym, const char *symname) > { > - enum export export; > const char *name; > > - if (strstarts(symname, "__ksymtab")) > - export = export_from_secname(info, get_secindex(info, sym)); > - > switch (sym->st_shndx) { > case SHN_COMMON: > if (strstarts(symname, "__gnu_lto_")) { > @@ -724,7 +720,11 @@ static void handle_symbol(struct module *mod, struct elf_info *info, > default: > /* All exported symbols */ > if (strstarts(symname, "__ksymtab_")) { > + enum export export; > + > name = symname + strlen("__ksymtab_"); > + export = export_from_secname(info, > + get_secindex(info, sym)); > sym_add_exported(name, mod, export); > } > if (strcmp(symname, "init_module") == 0) > -- > 2.32.0 > -- Thanks, ~Nick Desaulniers
Powered by blists - more mailing lists