linux-kernel - Re: [PATCH v2 2/2] libata: Inline ata_qc_new_init() in ata_scsi_qc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220405055252.GA23698@lst.de>
Date:   Tue, 5 Apr 2022 07:52:52 +0200
From:   Christoph Hellwig <hch@....de>
To:     John Garry <john.garry@...wei.com>
Cc:     damien.lemoal@...nsource.wdc.com, hch@....de,
        linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH v2 2/2] libata: Inline ata_qc_new_init() in
 ata_scsi_qc_new()

On Mon, Apr 04, 2022 at 10:53:10PM +0800, John Garry wrote:
> From: Christoph Hellwig <hch@....de>
> 
> It is a bit pointless to have ata_qc_new_init() in libata-core.c since it
> pokes scsi internals, so inline it in ata_scsi_qc_new() (in libata-scsi.c).
> 
> <Christoph, please provide signed-off-by>
> [jpg, Take Christoph's change from list and form into a patch]
> Signed-off-by: John Garry <john.garry@...wei.com>

Signed-off-by: Christoph Hellwig <hch@....de>

Although I still think merging the two patches into one to avoid all
the churn would be much better.