linux-kernel - Re: [PATCH 3/3] ASoC: atmel-ssc: replace usage of found with dedicated list iterator variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a82fb96b-6c34-25ed-47bc-53a755366676@microchip.com>
Date:   Tue, 5 Apr 2022 06:44:31 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <jakobkoschel@...il.com>
CC:     <arnd@...db.de>, <gregkh@...uxfoundation.org>,
        <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <Claudiu.Beznea@...rochip.com>, <cezary.rojewski@...el.com>,
        <pierre-louis.bossart@...ux.intel.com>,
        <liam.r.girdwood@...ux.intel.com>, <yang.jie@...ux.intel.com>,
        <broonie@...nel.org>, <perex@...ex.cz>, <tiwai@...e.com>,
        <orsonzhai@...il.com>, <baolin.wang7@...il.com>,
        <zhang.lyra@...il.com>, <yangyingliang@...wei.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org>,
        <rppt@...nel.org>, <bjohannesmeyer@...il.com>, <c.giuffrida@...nl>,
        <h.j.bos@...nl>
Subject: Re: [PATCH 3/3] ASoC: atmel-ssc: replace usage of found with
 dedicated list iterator variable

On 01.04.2022 00:50, Jakob Koschel wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
> 
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
> 
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
> 
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
> Signed-off-by: Jakob Koschel <jakobkoschel@...il.com>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>

Thanks!