linux-kernel - Re: [PATCH] fs/proc/kcore.c: remove check of list iterator against head past the loop body

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <32C4FBEE-D56B-46AA-AB95-1A17B5CC0A87@gmail.com>
Date:   Tue, 5 Apr 2022 10:48:30 +0200
From:   Jakob Koschel <jakobkoschel@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Mike Rapoport <rppt@...nel.org>,
        David Hildenbrand <david@...hat.com>,
        Oscar Salvador <osalvador@...e.de>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@...il.com>,
        Cristiano Giuffrida <c.giuffrida@...nl>,
        "Bos, H.J." <h.j.bos@...nl>
Subject: Re: [PATCH] fs/proc/kcore.c: remove check of list iterator against
 head past the loop body



> On 5. Apr 2022, at 00:55, Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> On Fri, 1 Apr 2022 09:19:57 +0200 Jakob Koschel <jakobkoschel@...il.com> wrote:
> 
>>> Speaking of limiting scope...
>> 
>> Fair point :-)
>> 
>> I see you have applied this already to the -mm tree. Shall I still move the iterator?
>> The hope is to remove the 'iter' variable altogether when there are no uses after
>> the loop anymore.
> 
> I don't really understand the question.

Basically I was asking if I should send a v2 with the change you suggested.
> 
> My plan is to merge your patch with my fixlet immediately prior to
> sending upstream.

ok, great. Even better, so ignore my question.

Thanks,
Jakob