linux-kernel - Re: [PATCH 1/5] staging: r8188eu: remove HAL_DEF_IS_SUPPORT_ANT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 5 Apr 2022 11:07:19 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] staging: r8188eu: remove HAL_DEF_IS_SUPPORT_ANT_DIV

Hi Greg,

On 4/4/22 16:32, Greg KH wrote:
>> +bool support_ant_div(struct adapter *adapter)
> 
> That's a very odd function name to add to the kernel's global namespace
> :(
> 
> Pleas emake it more obvious what this is for, with the driver name as
> part of the prefix?
> 

Looking again at this I notice it can be made a static function in 
rtw_cmd.c.

I'll rework the series and make the function static with a more
descriptive name.

thanks,
Michael