linux-kernel - Re: [Linux 5.18-rc1] WARNING: CPU: 1 PID: 0 at kernel/sched/fair.c:3355 update_blocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df464935-9743-0f4c-1edb-e0204bab938e@gnuweeb.org>
Date:   Tue, 5 Apr 2022 20:29:08 +0700
From:   Ammar Faizi <ammarfaizi2@...weeb.org>
To:     Dietmar Eggemann <dietmar.eggemann@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:     Ben Segall <bsegall@...gle.com>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Mel Gorman <mgorman@...e.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [Linux 5.18-rc1] WARNING: CPU: 1 PID: 0 at
 kernel/sched/fair.c:3355 update_blocked_averages

On 4/5/22 7:21 PM, Dietmar Eggemann wrote:
> Maybe you could split the SCHED_WARN_ON so we know which signal causes this?
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index d4bd299d67ab..0d45e09e5bfc 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3350,9 +3350,9 @@ static inline bool cfs_rq_is_decayed(struct cfs_rq
> *cfs_rq)
>           * Make sure that rounding and/or propagation of PELT values never
>           * break this.
>           */
> -       SCHED_WARN_ON(cfs_rq->avg.load_avg ||
> -                     cfs_rq->avg.util_avg ||
> -                     cfs_rq->avg.runnable_avg);
> +       SCHED_WARN_ON(cfs_rq->avg.load_avg);
> +       SCHED_WARN_ON(cfs_rq->avg.util_avg);
> +       SCHED_WARN_ON(cfs_rq->avg.runnable_avg);
> 
>          return true;
>   }

error: corrupt patch at line 6

Trivial enough, fixed it. Compiling now...

ammarfaizi2@...egral2:~/work/linux.work$ git log -n1
commit 3123109284176b1532874591f7c81f3837bbdc17 (HEAD -> master, tag: v5.18-rc1, @torvalds/linux/master)
Author: Linus Torvalds <torvalds@...ux-foundation.org>
Date:   Sun Apr 3 14:08:21 2022 -0700

     Linux 5.18-rc1
ammarfaizi2@...egral2:~/work/linux.work$ git diff
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d4bd299d67ab..0d45e09e5bfc 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3350,9 +3350,9 @@ static inline bool cfs_rq_is_decayed(struct cfs_rq *cfs_rq)
  	 * Make sure that rounding and/or propagation of PELT values never
  	 * break this.
  	 */
-	SCHED_WARN_ON(cfs_rq->avg.load_avg ||
-		      cfs_rq->avg.util_avg ||
-		      cfs_rq->avg.runnable_avg);
+	SCHED_WARN_ON(cfs_rq->avg.load_avg);
+	SCHED_WARN_ON(cfs_rq->avg.util_avg);
+	SCHED_WARN_ON(cfs_rq->avg.runnable_avg);
  
  	return true;
  }
ammarfaizi2@...egral2:~/work/linux.work$

-- 
Ammar Faizi