linux-kernel - Re: [PATCH v1 1/3] gpiolib: Split out for_each_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkxYTXbJqpBp4H0a@smile.fi.intel.com>
Date:   Tue, 5 Apr 2022 17:55:09 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/3] gpiolib: Split out for_each_gpio_desc() macro

On Tue, Apr 05, 2022 at 02:21:42PM +0200, Bartosz Golaszewski wrote:
> On Wed, Mar 30, 2022 at 4:59 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:

...

> > -#define for_each_gpio_desc_with_flag(i, gc, desc, flag)                \
> > +#define for_each_gpio_desc(i, gc, desc)                                \
> 
> While at it: how about declaring the i variable in the loop definition?

It will require changes in the users, so, I will do it as a prerequisite
separate change.

> >         for (i = 0, desc = gpiochip_get_desc(gc, i);            \
> >              i < gc->ngpio;                                     \
> > -            i++, desc = gpiochip_get_desc(gc, i))              \
> > +            i++, desc = gpiochip_get_desc(gc, i))

-- 
With Best Regards,
Andy Shevchenko