linux-kernel - Re: [PATCH 2/3] staging: rtl8712: add two validation check in r8712_init_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tencent_452951FCBB813C31CBE516716C537884D70A@qq.com>
Date:   Tue, 5 Apr 2022 09:10:24 +0800
From:   <xkernel.wang@...mail.com>
To:     "'Greg KH'" <gregkh@...uxfoundation.org>
Cc:     <Larry.Finger@...inger.net>, <florian.c.schilhabel@...glemail.com>,
        <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] staging: rtl8712: add two validation check in r8712_init_drv_sw()

On Monday, April 4, 2022 10:30 PM +0800, gregkh@...uxfoundation.org wrote:
> You just leaked memory :(
>
> please please please test these types of "fix up error handling"
> changes, as there are lots and lots of ways to get these wrong.
>

It seems that you missed the third email in this series.

In fact, I did not ignore the memory leak problem. But considering that there are other paths which can also lead to memory leak, I separated another patch to deal with them specifically.

In the next version, I will adjust the sequence of the patches and add some descriptions to explicitly show the relations.

--
Regards,
Xiaoke Wang