linux-kernel - Re: [PATCH 5.16 0199/1017] PCI: xgene: Revert "PCI: xgene: Fix IB window setup"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkxjbVp3W2LeVIeL@xps13.dannf>
Date:   Tue, 5 Apr 2022 09:42:37 -0600
From:   dann frazier <dann.frazier@...onical.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Marc Zyngier <maz@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Toan Le <toan@...amperecomputing.com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Stéphane Graber <stgraber@...ntu.com>
Subject: Re: [PATCH 5.16 0199/1017] PCI: xgene: Revert "PCI: xgene: Fix IB
 window setup"

On Tue, Apr 05, 2022 at 09:18:32AM +0200, Greg Kroah-Hartman wrote:
> From: Marc Zyngier <maz@...nel.org>
> 
> commit 825da4e9cec68713fbb02dc6f71fe1bf65fe8050 upstream.
> 
> Commit c7a75d07827a ("PCI: xgene: Fix IB window setup") tried to
> fix the damages that 6dce5aa59e0b ("PCI: xgene: Use inbound resources
> for setup") caused, but actually didn't improve anything for some
> plarforms (at least Mustang and m400 are still broken).
> 
> Given that 6dce5aa59e0b has been reverted, revert this patch as well,
> restoring the PCIe support on XGene to its pre-5.5, working state.
> 
> Link: https://lore.kernel.org/r/YjN8pT5e6/8cRohQ@xps13.dannf
> Link: https://lore.kernel.org/r/20220321104843.949645-3-maz@kernel.org
> Fixes: c7a75d07827a ("PCI: xgene: Fix IB window setup")
> Signed-off-by: Marc Zyngier <maz@...nel.org>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
> Cc: stable@...r.kernel.org
> Cc: Rob Herring <robh@...nel.org>
> Cc: Toan Le <toan@...amperecomputing.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
> Cc: Krzysztof Wilczyński <kw@...ux.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Stéphane Graber <stgraber@...ntu.com>
> Cc: dann frazier <dann.frazier@...onical.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/pci/controller/pci-xgene.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi Greg,

  I don't think it makes sense to apply this to 5.10.y, 5.15.y &
5.16.y w/o also applying a backport of 1874b6d7ab1, because without
that we will regress support for Stéphane's X-Gene2-based systems. The
backport of 1874b6d7ab1 was rejected for these trees because it doesn't
apply cleanly, but I've just submitted new versions that do.

  -dann