linux-kernel - Re: [PATCH 2/2] staging: r8188eu: Add line after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkxIDdCrJT1rV3SZ@kroah.com>
Date:   Tue, 5 Apr 2022 15:45:49 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Larry Finger <Larry.Finger@...inger.net>
Cc:     Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>,
        outreachy@...ts.linux.dev, phil@...lpotter.co.uk,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: r8188eu: Add line after declarations

On Mon, Apr 04, 2022 at 01:47:33PM -0500, Larry Finger wrote:
> On 4/4/22 09:39, Alaa Mohamed wrote:
> > Reported by checkpatch:
> > 
> > WARNING: Missing a blank line after declarations
> > 
> > Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
> > ---
> >   drivers/staging/r8188eu/core/rtw_br_ext.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
> > index 7c664f80fa99..f7811b46db1c 100644
> > --- a/drivers/staging/r8188eu/core/rtw_br_ext.c
> > +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
> > @@ -313,6 +313,7 @@ void nat25_db_cleanup(struct adapter *priv)
> >   	for (i = 0; i < NAT25_HASH_SIZE; i++) {
> >   		struct nat25_network_db_entry *f;
> > +
> >   		f = priv->nethash[i];
> >   		while (f) {
> >   			struct nat25_network_db_entry *g;
> > @@ -339,12 +340,12 @@ void nat25_db_expire(struct adapter *priv)
> >   	for (i = 0; i < NAT25_HASH_SIZE; i++) {
> >   		struct nat25_network_db_entry *f;
> > -		f = priv->nethash[i];
> > +		f = priv->nethash[i];
> >   		while (f) {
> >   			struct nat25_network_db_entry *g;
> > -			g = f->next_hash;
> > +			g = f->next_hash;
> >   			if (__nat25_has_expired(f)) {
> >   				if (atomic_dec_and_test(&f->use_count)) {
> >   					if (priv->scdb_entry == f) {
> 
> Acked_by: Larry Finger <Larry.Finger@...inger.net>
> 
> That applies to both patches.

b4 doesn't pick this ack up for both patches, you either need to do it
on the 0/X message, or on each one individually.

thanks,

greg k-h