linux-kernel - Re: [PATCH] kbuild: uapi: use -fsyntax-only rather than -S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 5 Apr 2022 10:53:57 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Dmitry V. Levin" <ldv@...linux.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: uapi: use -fsyntax-only rather than -S

On Thu, Mar 31, 2022 at 3:34 AM Nick Desaulniers
<ndesaulniers@...gle.com> wrote:
>
> The UAPI header tests are checking that the generated headers do not
> have syntax errors. There's no need to run the rest of the compilation
> pipeline after semantic analysis has run. Replace -S -o /dev/null with
> -fsyntax-only.
>

Applied to linux-kbuild.
Thanks.


> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
> ---
>  usr/include/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/usr/include/Makefile b/usr/include/Makefile
> index 7b283d43f00d..bf193e205dbe 100644
> --- a/usr/include/Makefile
> +++ b/usr/include/Makefile
> @@ -89,7 +89,7 @@ extra-y := $(patsubst $(obj)/%.h,%.hdrtest, $(shell find $(obj) -name '*.h' 2>/d
>  # Include the header twice to detect missing include guard.
>  quiet_cmd_hdrtest = HDRTEST $<
>        cmd_hdrtest = \
> -               $(CC) $(c_flags) -S -o /dev/null -x c /dev/null \
> +               $(CC) $(c_flags) -fsyntax-only -x c /dev/null \
>                         $(if $(filter-out $(no-header-test), $*.h), -include $< -include $<); \
>                 $(PERL) $(srctree)/$(src)/headers_check.pl $(obj) $(SRCARCH) $<; \
>                 touch $@
>
> base-commit: 74164d284b2909de0ba13518cc063e9ea9334749
> --
> 2.35.1.1021.g381101b075-goog
>


-- 
Best Regards
Masahiro Yamada