linux-kernel - Re: [PATCH v3 4/5] dt-bindings: spi: add binding doc for spi-mtk-snfi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJsYDVLaXAoL=TcPun6rckcA_cdUS-zFy_7M6uCpfzX+jbQEag@mail.gmail.com>
Date:   Tue, 5 Apr 2022 10:55:51 +0800
From:   Chuanhong Guo <gch981213@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>, linux-spi@...r.kernel.org,
        Matthias Brugger <matthias.bgg@...il.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Richard Weinberger <richard@....at>,
        Pratyush Yadav <p.yadav@...com>,
        linux-arm-kernel@...ts.infradead.org,
        Cai Huoqing <cai.huoqing@...ux.dev>,
        Roger Quadros <rogerq@...nel.org>,
        Yu Kuai <yukuai3@...wei.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        linux-mediatek@...ts.infradead.org,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        devicetree@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        linux-kernel@...r.kernel.org, Paul Cercueil <paul@...pouillou.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Colin Ian King <colin.king@...el.com>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v3 4/5] dt-bindings: spi: add binding doc for spi-mtk-snfi

Hi Rob!

On Tue, Apr 5, 2022 at 12:09 AM Rob Herring <robh@...nel.org> wrote:
> [...]
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.example.dt.yaml: spi@...0d000: 'ecc-engine' is a required property
>         From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml
> Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.example.dt.yaml:0:0: /example-0/soc/spi@...0d000/flash@0: failed to match any schema with compatible: ['spi-nand']

I ran the tests myself and it's only complaining about the ecc-engine name:

/home/user/src/kernels/linux/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.example.dtb:
spi@...0d000: 'ecc-engine' is a required property
>From schema: /home/user/src/kernels/linux/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml

It says nothing about the spi-nand part.
I'd like to keep the flash@0 node in the example to demonstrate the
nand-ecc-engine usage. What should I do?
-- 
Regards,
Chuanhong Guo