linux-kernel - Re: [RFC PATCH 0/8] media: hantro: Add 10-bit support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4386971.LvFx2qVVIh@jernej-laptop>
Date:   Tue, 05 Apr 2022 20:40:38 +0200
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     ezequiel@...guardiasur.com.ar, p.zabel@...gutronix.de,
        Benjamin Gaignard <benjamin.gaignard@...labora.com>
Cc:     mchehab@...nel.org, nicolas@...fresne.ca, hverkuil-cisco@...all.nl,
        gregkh@...uxfoundation.org, wens@...e.org, samuel@...lland.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, linux-staging@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev
Subject: Re: [RFC PATCH 0/8] media: hantro: Add 10-bit support

Hi Benjamin!

Dne torek, 05. april 2022 ob 18:07:41 CEST je Benjamin Gaignard napisal(a):
> Le 27/02/2022 à 15:49, Jernej Skrabec a écrit :
> > First two patches add 10-bit formats to UAPI, third extends filtering
> > mechanism, fourth fixes incorrect assumption, fifth moves register
> > configuration code to proper place, sixth and seventh enable 10-bit
> > VP9 decoding on Allwinner H6 and last increases core frequency on
> > Allwinner H6.
> > 
> > I'm sending this as RFC to get some comments:
> > 1. format definitions - are fourcc's ok? are comments/descriptions ok?
> > 2. is extended filtering mechanism ok?
> > 
> > I would also like if these patches are tested on some more HW.
> > Additionally, can someone test tiled P010?
> > 
> > Please take a look.
> 
> Hi Jernej,
> 
> I have create a branch to test this series with VP9 and HEVC:
> https://gitlab.collabora.com/benjamin.gaignard/for-upstream/-/tree/10bit_imx
> 8m Feel free to pick what I may need in it.
> 
> That doesn't improve fluster scores, I think more dev are still needed in
> GST before getting something fully functional.
> Anyway I able to select P010 pixel format if the input is a 10bit bitstream.

What kind of improvements do you expect? Actually, this series is designed to 
change nothing for platforms, where 10-bit format is not added into the list 
of supported formats. I think reasons are quite obvious. First, not every 
device may support 10-bit output. Second, as you might already figured it out, 
registers in this series are set only for legacy cores. I have no idea, what 
needs to be done for newer ones, since I don't have them. Anyway, I tested 
this with fluster and only one additional test passes, because it is the only 
one for 10-bit YUV420.

Best regards,
Jernej