linux-kernel - Re: [RESEND PATCH 06/11] brcmfmac: sdio: Fix undefined behavior due to shift overflowing the constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d8c4ab5-8952-87be-aad1-67d3cd9f4eb0@broadcom.com>
Date:   Tue, 5 Apr 2022 21:11:08 +0200
From:   Arend van Spriel <arend.vanspriel@...adcom.com>
To:     Borislav Petkov <bp@...en8.de>, Kalle Valo <kvalo@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Arend van Spriel <aspriel@...il.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        brcm80211-dev-list.pdl@...adcom.com, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [RESEND PATCH 06/11] brcmfmac: sdio: Fix undefined behavior due
 to shift overflowing the constant

On 4/5/2022 6:55 PM, Borislav Petkov wrote:
> Fix:
> 
>    drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: In function ‘brcmf_sdio_drivestrengthinit’:
>    drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3798:2: error: case label does not reduce to an integer constant
>      case SDIOD_DRVSTR_KEY(BRCM_CC_43143_CHIP_ID, 17):
>      ^~~~
>    drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3809:2: error: case label does not reduce to an integer constant
>      case SDIOD_DRVSTR_KEY(BRCM_CC_43362_CHIP_ID, 13):
>      ^~~~
> 
> See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
> details as to why it triggers with older gccs only.

The details aren't that gory ;-)

Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: Arend van Spriel <aspriel@...il.com>
> Cc: Franky Lin <franky.lin@...adcom.com>
> Cc: Hante Meuleman <hante.meuleman@...adcom.com>
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: brcm80211-dev-list.pdl@...adcom.com
> Cc: netdev@...r.kernel.org

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)