linux-kernel - Re: [PATCH V7 03/10] PCI: Create PCI library functions in support of DOE mailboxes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Apr 2022 16:22:11 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Lukas Wunner <lukas@...ner.de>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Alison Schofield <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Ben Widawsky <ben.widawsky@...el.com>,
        linux-kernel@...r.kernel.org, linux-cxl@...r.kernel.org,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH V7 03/10] PCI: Create PCI library functions in support of
 DOE mailboxes.

On Sat, Apr 02, 2022 at 04:48:45PM +0200, Lukas Wunner wrote:
> On Thu, Mar 31, 2022 at 08:19:56AM -0700, Ira Weiny wrote:
> > On Wed, Mar 30, 2022 at 10:50:31PM -0700, Christoph Hellwig wrote:
> > > On Wed, Mar 30, 2022 at 04:59:13PM -0700, ira.weiny@...el.com wrote:
> > > > Introduced in a PCI v6.0[1], DOE provides a config space based mailbox
> > > > with standard protocol discovery.  Each mailbox is accessed through a
> > > > DOE Extended Capability.
> > > 
> > > I really don't think this should be built unconditionally and bloat
> > > every single kernel built with PCI support.
> > 
> > I can add a Kconfig.
> 
> Ideally, that config option should live in the pcie/ subdirectory,
> i.e. in drivers/pci/pcie/Kconfig, alongside drivers/pci/pcie/doe.c,
> as we try to consolidate PCIe-specific features there and reserve
> core code in drivers/pci/*.c for functionality that also applies
> to Conventional PCI.

Thanks for letting me know about this direction.  I was unaware of this.

I'll move the file no problem, thanks,
Ira

> 
> Thanks,
> 
> Lukas