linux-kernel - Re: [PATCH 2/2] timers: Fix warning in __run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220405214319.GA1359137@lothringen>
Date:   Tue, 5 Apr 2022 23:43:19 +0200
From:   Frederic Weisbecker <frederic@...nel.org>
To:     Anna-Maria Behnsen <anna-maria@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH 2/2] timers: Fix warning in __run_timers()

On Tue, Apr 05, 2022 at 09:17:32PM +0200, Anna-Maria Behnsen wrote:
> When the timer base is empty, base::next_expiry is set to base::clk +
> NEXT_TIMER_MAX_DELTA and base::next_expiry_recalc is false. When no timer
> is queued until jiffies reaches base::next_expiry value, the warning for
> not finding any expired timer and base::next_expiry_recalc is false in
> __run_timers() triggers.
> 
> To prevent triggering the warning in this valid scenario
> base::timers_pending needs to be added to the warning condition.
> 
> Fixes: 31cd0e119d50 ("timers: Recalculate next timer interrupt only when necessary")
> Reported-by: Johannes Berg <johannes@...solutions.net>
> Signed-off-by: Anna-Maria Behnsen <anna-maria@...utronix.de>

Reviewed-by: Frederic Weisbecker <frederic@...nel.org>

Thanks!