linux-kernel - Re: [PATCH] drm/format_helper: fix a kernel-doc typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c544d79e-90ec-7bbe-77ad-de96a700d711@infradead.org>
Date:   Tue, 5 Apr 2022 07:39:30 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        Simon Ser <contact@...rsion.fr>
Cc:     linux-kernel@...r.kernel.org,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/format_helper: fix a kernel-doc typo



On 4/4/22 23:26, Javier Martinez Canillas wrote:
> On 4/5/22 08:12, Simon Ser wrote:
>> On Monday, April 4th, 2022 at 23:35, Randy Dunlap <rdunlap@...radead.org> wrote:
>>
>>> On 4/4/22 09:04, Simon Ser wrote:
>>>
>>>> Both doc patches pushed, thanks. I had to manually edit them because they
>>>> wouldn't apply cleanly. Next time, please use git-send-email (see
>>>> https://git-send-email.io/ for setup instructions).
>>>
>>> That's odd. I did use 'git send-email' and I don't usually have any
>>> problems (AFAIK). I'll check those setup instructions.
>>
>> Hm, maybe the issue isn't git-send-email, but the way the patch was
>> generated? I had to manually edit these lines for the first patch to work:
>>
>>     --- linux-next-20211217.orig/include/drm/drm_file.h
>>     +++ linux-next-20211217/include/drm/drm_file.h
>>
>> I changed these to:
>>
>>     --- a/include/drm/drm_file.h
>>     +++ b/include/drm/drm_file.h
>>
>> This wasn't enough for the second patch, I had to re-do the changes by hand
>> from scratch.
>>
> 
> Yes, I believe the suggestion should be to use git-format-patch instead.
> 
> To make sure that was is posted can be consumed by the git-am command.

Considering that I am not using git, I think it will be difficult
to use git-format-patch.

(git-send-email is independent of git.)

Still, this is the first time in many years that I have heard
of this problem.

Thanks for the info and insights.

-- 
~Randy