linux-kernel - Re: [PATCH 5.15 746/913] ARM: ftrace: avoid redundant loads or clobbering IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXEiOkmMWGr2TT=SdTqPVZotqwAho=rWLuF9=xiGSgGB0w@mail.gmail.com>
Date:   Tue, 5 Apr 2022 19:17:21 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "# 3.4.x" <stable@...r.kernel.org>,
        "Steven Rostedt (Google)" <rostedt@...dmis.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.15 746/913] ARM: ftrace: avoid redundant loads or
 clobbering IP

On Tue, 5 Apr 2022 at 18:52, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Tue, Apr 05, 2022 at 12:01:19PM +0200, Ard Biesheuvel wrote:
> > On Tue, 5 Apr 2022 at 11:54, Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org> wrote:
> > >
> > > From: Ard Biesheuvel <ardb@...nel.org>
> > >
> > > [ Upstream commit d11967870815b5ab89843980e35aab616c97c463 ]
> > >
> > > Tweak the ftrace return paths to avoid redundant loads of SP, as well as
> > > unnecessary clobbering of IP.
> > >
> > > This also fixes the inconsistency of using MOV to perform a function
> > > return, which is sub-optimal on recent micro-architectures but more
> > > importantly, does not perform an interworking return, unlike compiler
> > > generated function returns in Thumb2 builds.
> > >
> > > Let's fix this by popping PC from the stack like most ordinary code
> > > does.
> > >
> > > Signed-off-by: Ard Biesheuvel <ardb@...nel.org>
> > > Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> > > Signed-off-by: Sasha Levin <sashal@...nel.org>
> >
> > Please drop all the 32-bit ARM patches authored by me from the stable
> > queues except the ones that have fixes tags. These are highly likely
> > to cause an explosion of regressions, and they should have never been
> > selected, as I don't remember anyone proposing these for stable.
>
> From what I can tell, that is only this commit.  I'll go drop it from
> all trees, thanks.
>

Ah ok, that's not so bad then. But still better to avoid it.