linux-kernel - Re: [PATCH v2 3/4] mtd: phram: Allow probing via reserved-memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Apr 2022 13:25:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>, vigneshr@...com,
        richard@....at, miquel.raynal@...tlin.com, joern@...ybastard.org
Cc:     kbuild-all@...ts.01.org, kernel@...s.com,
        Vincent Whitchurch <vincent.whitchurch@...s.com>,
        linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org,
        robh+dt@...nel.org, krzk+dt@...nel.org, frowand.list@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] mtd: phram: Allow probing via reserved-memory

Hi Vincent,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mtd/mtd/next]
[also build test ERROR on mtd/mtd/fixes robh/for-next v5.18-rc1 next-20220405]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Vincent-Whitchurch/mtd-phram-improvements/20220406-070357
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
config: i386-randconfig-a005 (https://download.01.org/0day-ci/archive/20220406/202204061349.puriUTMO-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/5f942c36259bf6194f9cc8ed7cbacdca28200e20
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Vincent-Whitchurch/mtd-phram-improvements/20220406-070357
        git checkout 5f942c36259bf6194f9cc8ed7cbacdca28200e20
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/mtd/devices/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/mtd/devices/phram.c:347:1: error: expected ',' or ';' before 'static'
     347 | static int phram_probe(struct platform_device *pdev)
         | ^~~~~~
>> drivers/mtd/devices/phram.c:372:27: error: 'phram_probe' undeclared here (not in a function); did you mean 'phram_write'?
     372 |         .probe          = phram_probe,
         |                           ^~~~~~~~~~~
         |                           phram_write


vim +347 drivers/mtd/devices/phram.c

   346	
 > 347	static int phram_probe(struct platform_device *pdev)
   348	{
   349		struct resource *res;
   350	
   351		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
   352		if (!res)
   353			return -ENOMEM;
   354	
   355		/* mtd_set_of_node() reads name from "label" */
   356		return register_device(pdev, NULL, res->start, resource_size(res),
   357				       PAGE_SIZE);
   358	}
   359	
   360	static int phram_remove(struct platform_device *pdev)
   361	{
   362		struct phram_mtd_list *phram = platform_get_drvdata(pdev);
   363	
   364		mtd_device_unregister(&phram->mtd);
   365		iounmap(phram->mtd.priv);
   366		kfree(phram);
   367	
   368		return 0;
   369	}
   370	
   371	static struct platform_driver phram_driver = {
 > 372		.probe		= phram_probe,
   373		.remove		= phram_remove,
   374		.driver		= {
   375			.name		= "phram",
   376			.of_match_table	= of_match_ptr(phram_of_match),
   377		},
   378	};
   379	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp