linux-kernel - [ammarfaizi2-block:robh/linux/dt/pop-pci-nodes 2/2] drivers/pci/of.c:29:6: warning: no previous prototype for function 'add_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202204060919.ixlG0hLi-lkp@intel.com>
Date:   Wed, 6 Apr 2022 10:01:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Rob Herring <robh@...nel.org>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:robh/linux/dt/pop-pci-nodes 2/2]
 drivers/pci/of.c:29:6: warning: no previous prototype for function
 'add_bus_props'

tree:   https://github.com/ammarfaizi2/linux-block robh/linux/dt/pop-pci-nodes
head:   b9198a9525a97d05b0bb2a7282fede92d7d2d93d
commit: b9198a9525a97d05b0bb2a7282fede92d7d2d93d [2/2] PCI: Create DT nodes if they don't exist
config: mips-buildonly-randconfig-r002-20220405 (https://download.01.org/0day-ci/archive/20220406/202204060919.ixlG0hLi-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c4a1b07d0979e7ff20d7d541af666d822d66b566)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/ammarfaizi2/linux-block/commit/b9198a9525a97d05b0bb2a7282fede92d7d2d93d
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block robh/linux/dt/pop-pci-nodes
        git checkout b9198a9525a97d05b0bb2a7282fede92d7d2d93d
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/pci/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/pci/of.c:18:21: warning: no previous prototype for function 'make_node' [-Wmissing-prototypes]
   struct device_node *make_node(void)
                       ^
   drivers/pci/of.c:18:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct device_node *make_node(void)
   ^
   static 
>> drivers/pci/of.c:29:6: warning: no previous prototype for function 'add_bus_props' [-Wmissing-prototypes]
   void add_bus_props(struct device_node *node)
        ^
   drivers/pci/of.c:29:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void add_bus_props(struct device_node *node)
   ^
   static 
   drivers/pci/of.c:60:6: warning: no previous prototype for function 'make_dev_node' [-Wmissing-prototypes]
   void make_dev_node(struct pci_dev *dev)
        ^
   drivers/pci/of.c:60:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void make_dev_node(struct pci_dev *dev)
   ^
   static 
   drivers/pci/of.c:88:21: warning: no previous prototype for function 'make_bus_node' [-Wmissing-prototypes]
   struct device_node *make_bus_node(struct pci_bus *bus)
                       ^
   drivers/pci/of.c:88:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct device_node *make_bus_node(struct pci_bus *bus)
   ^
   static 
   4 warnings generated.


vim +/add_bus_props +29 drivers/pci/of.c

    28	
  > 29	void add_bus_props(struct device_node *node)
    30	{
    31		struct property *prop;
    32		__be32 *val;
    33	
    34		prop = kzalloc(sizeof(*prop), GFP_KERNEL);
    35		prop->name = "ranges";
    36		prop->value = prop + 1;
    37		prop->next = node->properties;
    38		node->properties = prop;
    39	
    40		prop = kzalloc(sizeof(*prop) + sizeof(__be32), GFP_KERNEL);
    41		prop->name = "#address-cells";
    42		prop->value = prop + 1;
    43		prop->length = sizeof(__be32);
    44		val = prop->value;
    45		val[0] = __cpu_to_be32(3);
    46		prop->next = node->properties;
    47		node->properties = prop;
    48	
    49		prop = kzalloc(sizeof(*prop) + sizeof(__be32), GFP_KERNEL);
    50		prop->name = "#size-cells";
    51		prop->value = prop + 1;
    52		prop->length = sizeof(__be32);
    53		val = prop->value;
    54		val[0] = __cpu_to_be32(2);
    55		prop->next = node->properties;
    56		node->properties = prop;
    57	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp