linux-kernel - Re: [PATCH] regulator: rtq2134: Fix missing active_discharge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1649209630.3282.2.camel@richtek.com>
Date:   Wed, 6 Apr 2022 01:47:10 +0000
From:   cy_huang(黃啟原) <cy_huang@...htek.com>
To:     "axel.lin@...ics.com" <axel.lin@...ics.com>,
        "broonie@...nel.org" <broonie@...nel.org>
CC:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: rtq2134: Fix missing active_discharge_on
 setting

於 一，2022-04-04 於 10:25 +0800，Axel Lin 提到：
> The active_discharge_on setting was missed, so output discharge resistor
> is always disabled. Fix it.
>
> Fixes: 0555d41497de ("regulator: rtq2134: Add support for Richtek RTQ2134
> SubPMIC")
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/regulator/rtq2134-regulator.c | 1 +
>  1 file changed, 1 insertion(+)
>
Hi, Axel:
Thanks for the fix.

> diff --git a/drivers/regulator/rtq2134-regulator.c
> b/drivers/regulator/rtq2134-regulator.c
> index f21e3f8b21f2..8e13dea354a2 100644
> --- a/drivers/regulator/rtq2134-regulator.c
> +++ b/drivers/regulator/rtq2134-regulator.c
> @@ -285,6 +285,7 @@ static const unsigned int rtq2134_buck_ramp_delay_table[]
> = {
>  .enable_mask = RTQ2134_VOUTEN_MASK, \
>  .active_discharge_reg = RTQ2134_REG_BUCK##_id##_CFG0, \
>  .active_discharge_mask = RTQ2134_ACTDISCHG_MASK, \
> +.active_discharge_on = RTQ2134_ACTDISCHG_MASK, \
>  .ramp_reg = RTQ2134_REG_BUCK##_id##_RSPCFG, \
>  .ramp_mask = RTQ2134_RSPUP_MASK, \
>  .ramp_delay_table = rtq2134_buck_ramp_delay_table, \
************* Email Confidentiality Notice ********************

The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!