linux-kernel - Re: [PATCH v2 1/2] libata: Use scsi cmnd budget token for qc tag for SAS host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab6a13c1-90c4-63f0-c48d-c1faa0ae68fd@huawei.com>
Date:   Wed, 6 Apr 2022 08:12:08 +0100
From:   John Garry <john.garry@...wei.com>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>, <hch@....de>
CC:     <linux-kernel@...r.kernel.org>, <linux-ide@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] libata: Use scsi cmnd budget token for qc tag for
 SAS host

On 06/04/2022 02:39, Damien Le Moal wrote:
> On 4/4/22 23:53, John Garry wrote:
>> For attaining a qc tag for a SAS host we need to allocate a bit in
>> ata_port.sas_tag_allocated bitmap.
>>
>> However we already have a unique tag per device in range
>> [0, ATA_MAX_QUEUE) in the scsi cmnd budget token, so just use that
>> instead.
> 
> The valid range is [0, ATA_MAX_QUEUE - 1]. Tag ATA_MAX_QUEUE is 
> ATA_TAG_INTERNAL which is never allocated as a valid device tag but used 
> directly in ata_exec_internal().

But that is what I have in [0, ATA_MAX_QUEUE), which is same as [0, 
ATA_MAX_QUEUE - 1].

Thanks,
john