linux-kernel - Re: [PATCH v3 4/5] dt-bindings: spi: add binding doc for spi-mtk-snfi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Apr 2022 22:39:28 +0800
From:   Chuanhong Guo <gch981213@...il.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     Rob Herring <robh@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        linux-spi@...r.kernel.org,
        Matthias Brugger <matthias.bgg@...il.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Richard Weinberger <richard@....at>,
        Pratyush Yadav <p.yadav@...com>,
        linux-arm-kernel@...ts.infradead.org,
        Cai Huoqing <cai.huoqing@...ux.dev>,
        Roger Quadros <rogerq@...nel.org>,
        Yu Kuai <yukuai3@...wei.com>,
        linux-mediatek@...ts.infradead.org,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        devicetree@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        linux-kernel@...r.kernel.org, Paul Cercueil <paul@...pouillou.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Colin Ian King <colin.king@...el.com>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v3 4/5] dt-bindings: spi: add binding doc for spi-mtk-snfi

Hi!

On Tue, Apr 5, 2022 at 3:20 PM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
> You can try including spi-nand.yaml (like you do with
> spi-controller.yaml). You should no longer need to define
> nand-ecc-engine then as it is already described there?

This doesn't work. I added
- $ref: /schemas/mtd/spi-nand.yaml#
to the allOf property and dt_binding_check complains the following:

Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.example.dtb:
spi@...0d000: compatible:0: 'spi-nand' was expected
>From schema: /home/user/src/kernels/linux/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml

BTW I still can't get dt_binding_check to complain anything about
spi-nand. Here's the command I used:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- DT_CHECKER_FLAGS=-m
dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/mediatek,spi-mtk-snfi.yaml

-- 
Regards,
Chuanhong Guo