linux-kernel - Re: [PATCH] tty: serial: Prepare cleanup of powerpc's asm/prom.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <afeeec95-f2c3-2e58-eac6-97bf5872a042@kernel.org>
Date:   Wed, 6 Apr 2022 10:29:11 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-serial@...r.kernel.org
Subject: Re: [PATCH] tty: serial: Prepare cleanup of powerpc's asm/prom.h

On 02. 04. 22, 12:20, Christophe Leroy wrote:
> powerpc's asm/prom.h brings some headers that it doesn't
> need itself.
> 
> In order to clean it up, first add missing headers in
> users of asm/prom.h
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> ---
>   drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c | 1 -
>   drivers/tty/serial/mpc52xx_uart.c           | 2 ++
>   drivers/tty/serial/pmac_zilog.c             | 1 -
>   3 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c b/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c
> index 6a1cd03bfe39..108af254e8f3 100644
> --- a/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c
> +++ b/drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c
> @@ -25,7 +25,6 @@
>   #include <asm/io.h>
>   #include <asm/irq.h>
>   #include <asm/fs_pd.h>
> -#include <asm/prom.h>
>   
>   #include <linux/serial_core.h>
>   #include <linux/kernel.h>
> diff --git a/drivers/tty/serial/mpc52xx_uart.c b/drivers/tty/serial/mpc52xx_uart.c
> index 8a6958377764..4ec785e4f9b1 100644
> --- a/drivers/tty/serial/mpc52xx_uart.c
> +++ b/drivers/tty/serial/mpc52xx_uart.c
> @@ -38,6 +38,8 @@
>   #include <linux/delay.h>
>   #include <linux/io.h>
>   #include <linux/of.h>
> +#include <linux/of_address.h>
> +#include <linux/of_irq.h>
>   #include <linux/of_platform.h>
>   #include <linux/clk.h>
>   
> diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c
> index 5d97c201ad88..c903085acb8d 100644
> --- a/drivers/tty/serial/pmac_zilog.c
> +++ b/drivers/tty/serial/pmac_zilog.c
> @@ -51,7 +51,6 @@
>   #include <asm/irq.h>
>   
>   #ifdef CONFIG_PPC_PMAC
> -#include <asm/prom.h>
>   #include <asm/machdep.h>
>   #include <asm/pmac_feature.h>
>   #include <asm/dbdma.h>


-- 
js
suse labs