linux-kernel - Re: [Linux-cachefs] [PATCH] fscache: Move fscache_cookies_seq_ops specific code under CONFIG_PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c6b191b-4a2e-0333-b0a3-f76bcd6b6515@linux.alibaba.com>
Date:   Wed, 6 Apr 2022 10:45:46 +0800
From:   JeffleXu <jefflexu@...ux.alibaba.com>
To:     Yue Hu <huyue2@...lpad.com>, dhowells@...hat.com,
        linux-cachefs@...hat.com
Cc:     linux-kernel@...r.kernel.org, zbestahu@....com, zbestahu@...il.com
Subject: Re: [Linux-cachefs] [PATCH] fscache: Move fscache_cookies_seq_ops
 specific code under CONFIG_PROC_FS



On 4/2/22 12:47 PM, Yue Hu wrote:
> fscache_cookies_seq_ops is only used in proc.c that is compiled under
> enabled CONFIG_PROC_FS, so move related code under this config. The
> same case exsits in internal.h.
> 
> Also, make fscache_lru_cookie_timeout static due to no user outside
> of cookie.c.
> 
> Signed-off-by: Yue Hu <huyue2@...lpad.com>
> ---
>  fs/fscache/cookie.c   | 4 +++-
>  fs/fscache/internal.h | 4 ++++
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/fscache/cookie.c b/fs/fscache/cookie.c
> index 9bb1ab5fe5ed..9d3cf0111709 100644
> --- a/fs/fscache/cookie.c
> +++ b/fs/fscache/cookie.c
> @@ -30,7 +30,7 @@ static DEFINE_SPINLOCK(fscache_cookie_lru_lock);
>  DEFINE_TIMER(fscache_cookie_lru_timer, fscache_cookie_lru_timed_out);
>  static DECLARE_WORK(fscache_cookie_lru_work, fscache_cookie_lru_worker);
>  static const char fscache_cookie_states[FSCACHE_COOKIE_STATE__NR] = "-LCAIFUWRD";
> -unsigned int fscache_lru_cookie_timeout = 10 * HZ;
> +static unsigned int fscache_lru_cookie_timeout = 10 * HZ;
>  
>  void fscache_print_cookie(struct fscache_cookie *cookie, char prefix)
>  {
> @@ -1069,6 +1069,7 @@ void __fscache_invalidate(struct fscache_cookie *cookie,
>  }
>  EXPORT_SYMBOL(__fscache_invalidate);
>  
> +#ifdef CONFIG_PROC_FS
>  /*
>   * Generate a list of extant cookies in /proc/fs/fscache/cookies
>   */
> @@ -1145,3 +1146,4 @@ const struct seq_operations fscache_cookies_seq_ops = {
>  	.stop   = fscache_cookies_seq_stop,
>  	.show   = fscache_cookies_seq_show,
>  };
> +#endif

Then I'm afraid fscache_cookies_seq_stop() and
fscache_cookies_seq_show() also need to be wrapped with "#ifdef
CONFIG_PROC_F" ...

-- 
Thanks,
Jeffle