linux-kernel - Re: [PATCH 1/3] dt-bindings: display: mediatek: Correct disp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42e890bef5927f2c4854c146f9bab2f974b64a48.camel@mediatek.com>
Date:   Wed, 6 Apr 2022 18:49:59 +0800
From:   Rex-BC Chen <rex-bc.chen@...iatek.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        <chunkuang.hu@...nel.org>, <robh+dt@...nel.org>,
        <krzk+dt@...nel.org>
CC:     <matthias.bgg@...il.com>, <p.zabel@...gutronix.de>,
        <airlied@...ux.ie>, <yongqiang.niu@...iatek.com>,
        <jason-jh.lin@...iatek.com>, <nancy.lin@...iatek.com>,
        <allen-kh.cheng@...iatek.com>, <dri-devel@...ts.freedesktop.org>,
        <linux-mediatek@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH 1/3] dt-bindings: display: mediatek: Correct disp_aal
 binding for MT8183

On Wed, 2022-04-06 at 12:38 +0200, AngeloGioacchino Del Regno wrote:
> Il 06/04/22 11:46, Rex-BC Chen ha scritto:
> > The driver data of MT8183 and MT8173 are different.
> > The value of has_gamma for MT8173 is true while the value of MT8183
> > is
> > false. Therefore, the compatible of disp_aal for MT8183 is not
> > suitable
> > for the compatible for MT8173.
> > 
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@...iatek.com>
> 
> Hello!
> Yes, I definitely agree with this change, it makes no sense to have
> both
> 8173 and 8183 compatibles for 8183 (and similar).
> 
> Though, please, add a note in this commit message advertising that
> the
> mistake was only in the yaml binding, as the driver doesn't require
> any
> functional changes, so that things are clear for people with less
> expertise
> on MediaTek platforms.
> 
> After that:
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>

Hello Angelo,

Thanks for your review.
I will add them to the commit message in next version.

BRs,
Rex