lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Apr 2022 11:07:01 +0200 From: Petr Mladek <pmladek@...e.com> To: John Ogness <john.ogness@...utronix.de> Cc: Sergey Senozhatsky <senozhatsky@...omium.org>, Steven Rostedt <rostedt@...dmis.org>, Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Marco Elver <elver@...gle.com>, Randy Dunlap <rdunlap@...radead.org>, Alexander Potapenko <glider@...gle.com>, Stephen Boyd <swboyd@...omium.org>, Nicholas Piggin <npiggin@...il.com> Subject: Re: [PATCH printk v2 01/12] printk: rename cpulock functions On Tue 2022-04-05 15:31:24, John Ogness wrote: > Since the printk cpulock is CPU-reentrant and since it is used > in all contexts, its usage must be carefully considered and > most likely will require programming locklessly. To avoid > mistaking the printk cpulock as a typical lock, rename it to > cpu_sync. The main functions then become: > > printk_cpu_sync_get_irqsave(flags); > printk_cpu_sync_put_irqrestore(flags); > > Add extra notes of caution in the function description to help > developers understand the requirements for correct usage. > > Signed-off-by: John Ogness <john.ogness@...utronix.de> Looks good the me. Reviewed-by: Petr Mladek <pmladek@...e.com> Best Regards, Petr
Powered by blists - more mailing lists