linux-kernel - RE: [PATCH v2 1/2] block: add sync_blockdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HK2PR04MB38910663E1666A0C74A5618781E79@HK2PR04MB3891.apcprd04.prod.outlook.com>
Date:   Wed, 6 Apr 2022 10:21:15 +0000
From:   "Yuezhang.Mo@...y.com" <Yuezhang.Mo@...y.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     Namjae Jeon <linkinjeon@...nel.org>,
        "sj1557.seo@...sung.com" <sj1557.seo@...sung.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "Andy.Wu@...y.com" <Andy.Wu@...y.com>,
        "Wataru.Aoyama@...y.com" <Wataru.Aoyama@...y.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>
Subject: RE: [PATCH v2 1/2] block: add sync_blockdev_range()

> From: Christoph Hellwig <hch@...radead.org>
> > --- a/block/bdev.c
> > +++ b/block/bdev.c
> > @@ -200,6 +200,16 @@ int sync_blockdev(struct block_device *bdev)  }
> > EXPORT_SYMBOL(sync_blockdev);
> >
> > +int sync_blockdev_range(struct block_device *bdev, loff_t lstart,
> > +loff_t lend) {
> > +	if (!bdev)
> > +		return 0;
> 
> This check isn't really needed, and I don't think we need a !CONFIG_BLOCK
> stub for this either.

sync_blockdev() and related helpers have this check and a !CONFIG_BLOCK stub.
I would like to understand the background of your comment, could you explain a little more?

Thanks.