linux-kernel - Re: [PATCH 5.15 327/913] lib: uninline simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk2P58P53btqLAgr@kroah.com>
Date:   Wed, 6 Apr 2022 15:04:39 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.15 327/913] lib: uninline simple_strntoull() as well

On Wed, Apr 06, 2022 at 03:34:52PM +0300, Alexey Dobriyan wrote:
> On Tue, Apr 05, 2022 at 09:23:09AM +0200, Greg Kroah-Hartman wrote:
> > From: Alexey Dobriyan <adobriyan@...il.com>
> > 
> > [ Upstream commit 839b395eb9c13ae56ea5fc3ca9802734a72293f0 ]
> > 
> > Codegen become bloated again after simple_strntoull() introduction
> > 
> > 	add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-224 (-224)
> 
> > -static unsigned long long simple_strntoull(const char *startp, size_t max_chars,
> > -					   char **endp, unsigned int base)
> > +static noinline unsigned long long simple_strntoull(const char *startp, size_t max_chars, char **endp, unsigned int base)
> 
> This patch doesn't fix any bugs, why it is selected?

Easy change to make the kernel a tiny bit smaller?