linux-kernel - Re: [PATCH v3 2/4] pinctrl: mvebu: pinctrl driver for 98DX2530 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk2JTo91sZHunEpN@lunn.ch>
Date:   Wed, 6 Apr 2022 14:36:30 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     linus.walleij@...aro.org, robh+dt@...nel.org,
        catalin.marinas@....com, will@...nel.org,
        gregory.clement@...tlin.com, sebastian.hesselbarth@...il.com,
        kostap@...vell.com, robert.marko@...tura.hr,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 2/4] pinctrl: mvebu: pinctrl driver for 98DX2530 SoC

On Wed, Apr 06, 2022 at 03:21:56PM +1200, Chris Packham wrote:
> This pinctrl driver supports the 98DX25xx and 98DX35xx family of chips
> from Marvell. It is based on the Marvell SDK with additions for various
> (non-gpio) pin configurations based on the datasheet.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> ---
> 
> Notes:
>     Changes in v3:
>     - Use mmio instead of syscon

Hi Chris

syscon is used when the register space is shared with other
devices. Is that not the case here? You can share mmio spaces, but you
have to use the correct call to reserve it, so that the system knows
it is to be shared. Or are all the pinctl registers contiguous and you
are only reserve just the registers you need, leaving other drivers
fee to take what they need?

I'm just trying to ensure you are not going to have trouble later when
you add other drivers.

    Andrew