linux-kernel - Re: [PATCH] ima: remove redundant initialization of pointer 'file'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a74d717535179188606dea3c68f56d35a86bac8.camel@linux.ibm.com>
Date:   Tue, 05 Apr 2022 08:43:24 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E . Hallyn" <serge@...lyn.com>,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] ima: remove redundant initialization of pointer 'file'.

On Tue, 2022-03-01 at 12:07 +0000, Colin Ian King wrote:
> The pointer 'file' is being initialized with a value that is never read,
> it is being re-assigned the same value later on closer to where it is
> being first used. The initialization is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> security/integrity/ima/ima_main.c:434:15: warning: Value stored to 'file'
> during its initialization is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

thanks,

Mimi