linux-kernel - Re: [PATCH 1/5] staging: r8188eu: use round

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d80845a-0ccb-b94f-a9c2-84559dcc0adc@gmail.com>
Date:   Wed, 6 Apr 2022 16:56:37 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Joe Perches <joe@...ches.com>, gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] staging: r8188eu: use round_up() instead of RND4()

On 4/6/22 11:54, Joe Perches wrote:
> On Wed, 2022-04-06 at 08:18 +0200, Michael Straube wrote:
>> Use in-kernel round_up() instead of custom RND4().
> []
>> diff --git a/drivers/staging/r8188eu/core/rtw_security.c b/drivers/staging/r8188eu/core/rtw_security.c
> []
>> @@ -63,7 +63,7 @@ void rtw_wep_encrypt(struct adapter *padapter, struct xmit_frame *pxmitframe)
>>   				arc4_crypt(ctx, payload + length, crc.f1, 4);
>>   
>>   				pframe += pxmitpriv->frag_len;
>> -				pframe = (u8 *)RND4((size_t)(pframe));
>> +				pframe = (u8 *)round_up((size_t)pframe, 4);
> 
> Perhaps use PTR_ALIGN
> 
> 				pframe = PTR_ALIGN(pframe, 4);
> 
> etc...

Sounds reasonable, I'll send v2 soon.

Thanks,
Michael