[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Yk2ugxQukjPmYbFL@robh.at.kernel.org>
Date: Wed, 6 Apr 2022 10:15:15 -0500
From: Rob Herring <robh@...nel.org>
To: Rex-BC Chen <rex-bc.chen@...iatek.com>
Cc: xinlei.lee@...iatek.com, chunkuang.hu@...nel.org,
p.zabel@...gutronix.de, airlied@...ux.ie, daniel@...ll.ch,
matthias.bgg@...il.com, dri-devel@...ts.freedesktop.org,
linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
Project_Global_Chrome_Upstream_Group@...iatek.com,
jitao.shi@...iatek.com
Subject: Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add
compatible for MediaTek MT8186
On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@...iatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@...iatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@...iatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Those are always allowed on any node with 'clocks', so no need to add
them here.
Rob
Powered by blists - more mailing lists